Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#BugFix: Issue #19 #47

Merged
merged 2 commits into from
Aug 29, 2016
Merged

#BugFix: Issue #19 #47

merged 2 commits into from
Aug 29, 2016

Conversation

9jaGuy
Copy link
Contributor

@9jaGuy 9jaGuy commented Apr 20, 2016

Doesn’t work in Google Chrome for Android

Doesn’t work in Google Chrome for Android
@iamdustan
Copy link
Collaborator

Merge conflicts and need a description of why this fixes the issue and why it won’t break other known scenarios.

@9jaGuy
Copy link
Contributor Author

9jaGuy commented Apr 20, 2016

keypress is deprecated in place of beforeinput -> beforeedit | https://www.w3.org/TR/DOM-Level-3-Events/#event-type-keypress

@iamdustan
Copy link
Collaborator

will this break environments that support keypress but don’t have support of beforeinput?

@9jaGuy
Copy link
Contributor Author

9jaGuy commented Apr 20, 2016

Yes but this should work in all modern browsers.

Also binding to onKeypress will cause character duplication as I have seen in my project.

Alternative will be bind to both 'keypress' and 'beforeinput' then ignore the other event which ever one gets fired first.

@zomars
Copy link

zomars commented May 6, 2016

Any resolution on this PR?

Altusvdm added a commit to yoco-tech/react-maskedinput that referenced this pull request Jul 5, 2016
@Heymdall
Copy link
Contributor

Any updates on this PR? That's strange, but can't find any info about onBeforeInput in React docs, but as I understand from here React already have fallback to keypress event for browsers, that doesn't support beforeInput event. So this PR should work in all browsers.

@9jaGuy
Copy link
Contributor Author

9jaGuy commented Aug 29, 2016

we should be good then

@iamdustan
Copy link
Collaborator

I'm going to release this under 3.3.0-beta.1 for folks to test and ensure there are no unintended consequences to this.

@iamdustan iamdustan merged commit eda4e4c into insin:master Aug 29, 2016
@AlexeySemin
Copy link

Doesn't work in Internet Explorer Edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants