-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#BugFix: Issue #19 #47
Conversation
Doesn’t work in Google Chrome for Android
Merge conflicts and need a description of why this fixes the issue and why it won’t break other known scenarios. |
keypress is deprecated in place of beforeinput -> beforeedit | https://www.w3.org/TR/DOM-Level-3-Events/#event-type-keypress |
will this break environments that support |
Yes but this should work in all modern browsers. Also binding to onKeypress will cause character duplication as I have seen in my project. Alternative will be bind to both 'keypress' and 'beforeinput' then ignore the other event which ever one gets fired first. |
Any resolution on this PR? |
Any updates on this PR? That's strange, but can't find any info about onBeforeInput in React docs, but as I understand from here React already have fallback to keypress event for browsers, that doesn't support beforeInput event. So this PR should work in all browsers. |
we should be good then |
I'm going to release this under 3.3.0-beta.1 for folks to test and ensure there are no unintended consequences to this. |
Doesn't work in Internet Explorer Edge |
Doesn’t work in Google Chrome for Android