Prior to this code change, the popup would only open if no answer was… #344
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… given, but if the consent were truly revokable the popup needs to also even if an answer has been given to always allow for the choice to be "revokable". This mainly applies to the "opt-out" type of consent since they can always changes their mind.
…wn. This PR also contains the revokable fix I had in a previous PR weeks ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this code change, the popup would only open if no answer was given, but if the consent were truly revokable the popup needs to be able to reopen even if an answer has been given to always allow for the choice to be "revokable". This mainly applies to the "opt-out" type of consent since the user can change their mind based on the GDPR standard or revokable consent.