Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 support #9

Merged
merged 4 commits into from Aug 15, 2022
Merged

Vue 3 support #9

merged 4 commits into from Aug 15, 2022

Conversation

EdwinHoksberg
Copy link

@EdwinHoksberg EdwinHoksberg commented Feb 8, 2022

It was pretty easy to port this library to Vue 3, I only had to change a few things:

I'm not sure what the best course of action is to create a new Vue 3 release for this package, since the current tag is 0.4.2 maybe we should bump that to 1.0 when this gets merged?

Fixes #8

@insky
Copy link
Owner

insky commented Feb 8, 2022

I must think how to deal with Vue2 projects that use this library. Any thoughts?

@EdwinHoksberg
Copy link
Author

I think we can do something like what https://github.com/Norserium/vue-advanced-cropper is doing, they have a master branch that targets Vue 2 and a vue-next that targets Vue 3. Looking at their versions in npmjs(https://www.npmjs.com/package/vue-advanced-cropper) they have two current tags, latest(which is version 1.x) and next(which is 2.x).

I don't know how this tagging and releasing works in the npmjs registry, but does this sound like a good idea to you?

@andaonlinefundraising
Copy link

Any update on this? :)

@insky
Copy link
Owner

insky commented Feb 28, 2022

O, so sorry. I need more time. Right now my country defending russian invasion, so I'm a little busy now. Hope in few days I'll return to your problem.
Glory to Ukraine!

@aloisdg
Copy link

aloisdg commented Feb 28, 2022

This PR is currently trending on HN. @insky you may want to limit it to contributors to prevent spam. Locking may limit emoji reaction though :/ (which will block people who wants to show their support)

This is considered a good common practice but in this context I guess letting people show their love cannot really be seen as "spam".

Good luck 🇺🇦

@envp
Copy link

envp commented Feb 28, 2022

This PR is currently trending on HN. @insky you may want to limit it to contributors to prevent spam. AFAIK, locking wont limit emoji reaction (which is a nice thing if people wants to show support)

I think that would be a good decision, trending issues tend to invite comments which eventually become a moderation burden.

@iamricks
Copy link

Good luck @insky ❤️

@gjsman
Copy link

gjsman commented Feb 28, 2022

War makes everything else quickly seem insignificant.

God be with you @insky, may you return home safely and victorious.

@jandrusk
Copy link

This PR is currently trending on HN. @insky you may want to limit it to contributors to prevent spam. Locking may limit emoji reaction though (which will block people who wants to show their support)

Long live Ukraine!

@deedubs
Copy link

deedubs commented Feb 28, 2022

@insky: I don't need your PRs, I need ammo

@pmarreck
Copy link

given that programmers are from everywhere now, and the vast majority of us are anti-war, I wonder what glories might happen if we combined forces...

Good luck @insky , Putin's going to suffer for this. Unfortunately, this is now going to dominate this PR thanks to HN. Please don't lock

@baverman
Copy link

@MaKiPL people find very different ways to cope with the situation. Laugh is definitely one of the most accessible means to cope.

@timweissenfels
Copy link

Hey, good luck with defending your Country ❤️

@Apacher122
Copy link

O, so sorry. I need more time. Right now my country defending russian invasion, so I'm a little busy now. Hope in few days I'll return to your problem. Glory to Ukraine!

Genuinely hope you're okay brother! Godspeed!

@RollingTL
Copy link

RollingTL commented Feb 28, 2022

O, so sorry. I need more time. Right now my country defending russian invasion, so I'm a little busy now. Hope in few days I'll return to your problem.

Let me express my admiration to brave people of Ukraine. I wish you victory. Kazakh people really understand the evil your are fighting with.
Sorry for offtopic fellow developers. For several days I read all about this war but this comment made me literally cry.

@batisteo
Copy link

✅ This branch has no conflicts with the base branch

Let’s make it that way IRL

@lmaydev
Copy link

lmaydev commented Feb 28, 2022

Russia thought they could just rebase and be done with it.

They didn't count on so many merge conflicts.

Stay safe my friend.

@alsoknownasdrew
Copy link

Героям слава!

@theunixman
Copy link

slava ukraine!

@adennnn
Copy link

adennnn commented Feb 28, 2022

O, so sorry. I need more time. Right now my country defending russian invasion, so I'm a little busy now. Hope in few days I'll return to your problem. Glory to Ukraine!

It is unfortunate. Glory to ukraine!!! <3 ukraine

@Ancientkingg
Copy link

I wish you and your country nothing but safety and prosperity ❤️

@lloydjatkinson
Copy link

🇺🇦

@insky
Copy link
Owner

insky commented Feb 28, 2022

Thank you, guys. Can I ask for your help? Russian fake sites must be DDOS-ed.
https://github.com/almerico/bombardier
Thanks forehead for any help

@jonstorer
Copy link

Good luck @insky 🇺🇦

@jandrusk
Copy link

Don't worry, Putin's TTL is getting shorter each day. 😂

@steven-tey
Copy link

You're a legend, @insky!! Слава Україні! 🇺🇦

@UmbReTHY
This comment was marked as a violation of GitHub Acceptable Use Policies
@nielsrobin
Copy link

@insky Slava Ukraini. I wish you and your family well and hope you and your country make it out of this Russian aggression somehow. But it might be time to close down this PR, wish I could continue to get updates from you, but it's clearily being brigadier by russian trolls trying to spread misinformation.

@MarcosBL
Copy link

MarcosBL commented Mar 7, 2022

Really hope you and your family are safe. Good luck Ukraine ! 🇺🇦

@insky
Copy link
Owner

insky commented Mar 7, 2022

Today is 12th day of war. Ukrainian army successfully restrains occupants, Glory to the Heroes!
Yesterday I’ve missed post because I’ve looking for new place to stay. We need move further ‘cause of some circumstances.

Glory to Ukraine! 🇺🇦

@pmarreck
Copy link

pmarreck commented Mar 8, 2022

@UmbReTHY Surely, 900 Azov members IN TOTAL and the "mere threat" of joining NATO justifies the warring against an entire peaceful European democracy and the slaughtering and terrorizing of innocents by an ex-Stasi/KGB asshole, right? GTFO. Our first mistake was doing business with communists and thus enriching their non-democratically-elected leaders. As soon as Ukraine joins NATO, Russia can go EABOD.

covid fraud

You mean the absolutely ridiculous difference between the official Russian COVID death toll and the best estimate according to excess deaths? That fraud? https://imgur.com/a/eDw8WaK taken from https://www.economist.com/graphic-detail/coronavirus-excess-deaths-estimates (Sidenote, the actual worldwide number is probably at least 20 million deaths)

May this latest nightmare end soon.

@theunixman
Copy link

Слава Украине

@insky
Copy link
Owner

insky commented Mar 8, 2022

Hi, guys. I’m really don’t want to moderate this thread, but in future all anti-Ukrainian lunges will be removed. à la guerre comme à la guerre.

Today I’ve planned my tomorrow route and settled refugee family. They fleed from Zaporizhzhia region and told me horrible things.

Glory to Ukraine! 🇺🇦

@theunixman
Copy link

@insky godspeed to you and yours!

@insky
Copy link
Owner

insky commented Mar 9, 2022

My plans destroyed again by circumstances, it has become a habit.
Today I moved to my parent’s flat for one night. In grocery store I’ve unexpectedly met my old friend from Kyiv, we played in one metal band many years ago. He is on the road to the west. Probability of such meeting very close to zero, it funned me.

Oh, yea, I’ve didn’t told you yet, I’m playing bass in two metal bands 😁

Glory to Ukraine! 🇺🇦

@aloisdg
Copy link

aloisdg commented Mar 9, 2022

🤘 Dawn Of Victory 🤘

@piersolenski
Copy link

@insky what are your metal bands called? have they got any stuff online? best wishes and Slava Ukraine! 🫂

@insky
Copy link
Owner

insky commented Mar 11, 2022

@insky what are your metal bands called? have they got any stuff online? best wishes and Slava Ukraine! 🫂

“Pomsta” and “Exact Division”
Both of them are on Apple and Google music, Spotify and other main platforms

@insky
Copy link
Owner

insky commented Mar 11, 2022

Yesterday we moved to Ivano-Frankivsk, my former classmate give us a shelter. At the early morning russian missiles strikes an airports of Ivano-Frankivsk, Lutsk and Dniper. This monsters fires civilians. I have no words to describe what I feel.

Glory to Ukraine! 🇺🇦
Death to the enemies!

@insky
Copy link
Owner

insky commented Mar 12, 2022

Yesterday evening we arrived in small town of Morshyn famous of its mineral water. We’ll stay here for a long time (if our luck doesn’t fail). Today my son played on the playground with other children for the first time in two weeks. I'm planning to return to work as soon as possible.

Glory to Ukraine! 🇺🇦

@theunixman
Copy link

Слава Украине товарищ

@insky
Copy link
Owner

insky commented Mar 16, 2022

Today 21st day of war, more than 100 children killed by russian soldiers, 21 hospitals and 2700 houses destroyed. More than 70% of russian people encourage war. Russia have no forgiveness.

Glory to Ukraine! 🇺🇦
Death to the enemies!

@theunixman
Copy link

slava ukraine!

@alekrutkowski
Copy link

Слава Україні! Chwała Ukrainie! 🇺🇦🇵🇱
Victory to the Heroes! The dark 💀putinist-russian💀 tyranny will suffer an enormous defeat, their increasing genocidal attacks on civilians are a symptom of the fear of the impending collapse.

@MaximeCrp
Copy link

Today 21st day of war, more than 100 children killed by russian soldiers, 21 hospitals and 2700 houses destroyed. More than 70% of russian people encourage war. Russia have no forgiveness.

Glory to Ukraine! 🇺🇦 Death to the enemies!

any updates on your side @insky ?

@insky
Copy link
Owner

insky commented Mar 21, 2022

Hi, guys. We are still in Morshyn, every night and day here are multiple air raid alerts, fortunately without strikes. Some regions including Kyiv sufferers from massive missile and artillery attacks. Looks like russia wants to fight all civilized world.

I’ve almost returned to my main job, our team is developing cross-chain DeFi application. It’s very hard to dive in work, there isn’t any table, nearby cafeterias are overcrowded and l must work on a chair or on a bed.

Glory to Ukraine! 🇺🇦

@insky
Copy link
Owner

insky commented Mar 24, 2022

Month ago the war has begun. Ukraine successfully defending against the world’s second strongest army. Our people are united as never before and victory will be ours at the cost of great grief.

I’m going to visit a military office tomorrow and maybe join our army. I’m a reserve officer with no combat experience so I can be called to training center. I have no fear just a huge anger.

Glory to Ukraine! 🇺🇦
Death to the enemies!

@aloisdg
Copy link

aloisdg commented Mar 30, 2022

and here I am writing fizzbuzzes... As a dev, I cant imagine having to join an army. Hope you are doing well.

@theunixman
Copy link

@insky good on you mate! As the russians are showing the world there's a lot of value in non combat roles, and the largest modern armies have something like 1:3 "tooth to tail". It looks like the Russians have the opposite. Please stay as safe as you can, and fight hard for you and yours.

@insky
Copy link
Owner

insky commented Mar 30, 2022

Hi, guys. Today I was at the military office third time and was postponed again. There are a lot of volunteers willing to join the army forces to defend Ukraine. Also, a lot of volunteers help supply military and medics, shelter and feed refugees, donate, etc. Russia shows all its monstrosity, deceit and lack of common sense.

Glory to Ukraine! 🇺🇦

@mar10p
Copy link

mar10p commented Apr 13, 2022

Best wishes and stay safe @insky! 🇺🇦

@insky
Copy link
Owner

insky commented Apr 14, 2022

April 14, day 50

The whole world shuddered from the atrocities of the russians. They used chemical, shrapnel, ignition, and thermostatic bombs, shelling hospitals, schools, and residential buildings. They killed, tortured, and raped civilians, even children.
Russian propaganda machine putting a lot of effort to spread fake information to hide their crimes.

Me and my family still in the town of Morshyn. I visited a military office again and again was postponed. Still attempting to return to a normal work schedule, but with no success.

Glory to Ukraine! 🇺🇦
Death to the enemies!

@insky
Copy link
Owner

insky commented Jun 3, 2022

June 3, day 100

To recap, Russia have failed at almost any of the initial goals, has shown itself a nation of fascists, the world has identified the problem and has united to help Ukraine, albeit not without gas-chortling feet draggers, particularly within the EU. Ukrainians are incredibly brave and strong, and the Ukrainian military has suddenly shown itself as one of the world's most strongest even with very limited and outdated military technology.

Couple days ago we've returned back home, to Kyiv. Very depressive to see destroyed and burned buildings, broken tanks, destroyed roads and bridges around the city. Standing in lines for gasoline and diesel can take up to several hours. But we at home and we are alive.

Glory to Ukraine! 🇺🇦
Death to the enemies!

@insky insky merged commit f8969e9 into insky:master Aug 15, 2022
@insky
Copy link
Owner

insky commented Aug 15, 2022

Updated to Vue 3.
PR was automatically closed, can't reopen it

@theunixman
Copy link

Thank you Insky! Hang in there friend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Error Cannot read properties of undefined (reading '_c')