penv-575 fix deserialize new param, fix test (#419)

insolar · Aug 18, 2020 · f291011 · f291011
1 parent 087c52e
commit f291011
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/internal/app/observer/collecting/transactions.go b/internal/app/observer/collecting/transactions.go
@@ -545,16 +545,22 @@ func (c *TxResultCollector) fromDepositToDeposit(
 	}
 
 	var txID insolar.Reference
-	err := insolar.Deserialize(request.Arguments, []interface{}{nil, nil, nil, &txID, nil})
+	err := insolar.Deserialize(request.Arguments, []interface{}{nil, nil, nil, &txID, nil, nil})
 	if err != nil {
 		log.Error(errors.Wrap(err, "failed to parse arguments"))
 		return nil
 	}
 
-	return &observer.TxResult{
+	tx := &observer.TxResult{
 		TransactionID: txID,
 		Fee:           "0",
 	}
+
+	if err = tx.Validate(); err != nil {
+		log.Error(errors.Wrap(err, "failed to validate transaction"))
+		return nil
+	}
+	return tx
 }
 
 type TxSagaResultCollector struct {

diff --git a/internal/app/observer/collecting/transactions_test.go b/internal/app/observer/collecting/transactions_test.go
@@ -514,7 +514,7 @@ func TestTxResultCollector_Collect(t *testing.T) {
 		defer mc.Finish()
 
 		txID := *insolar.NewRecordReference(gen.ID())
-		arguments, err := insolar.Serialize([]interface{}{nil, nil, nil, &txID, nil})
+		arguments, err := insolar.Serialize([]interface{}{nil, nil, nil, &txID, nil, nil})
 		require.NoError(t, err)
 		request := record.Material{
 			Virtual: record.Wrap(&record.IncomingRequest{