Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State refreshing #30

Merged
merged 1 commit into from Jul 27, 2021
Merged

State refreshing #30

merged 1 commit into from Jul 27, 2021

Conversation

theiskaa
Copy link
Member

@theiskaa theiskaa commented Jul 27, 2021

Resolves: #29

New features:

  • Added refresh functionality to BoxController
  • Fixed closeBoxAfterCompleting problem
  • Added functionality, which automatically moves indicator to text's right position when suggestion item is selected

Example of the main issue-resolving:

Need a boxController first of all. Create it and give it to the suggestion field. Then just call boxController.refresh!() when you want to update your FieldSuggestion widget.

official

Added refresh function to BoxController, improved textListener, added auto indicator moving functionality and + tests fro all the new features/bug-fixes
@theiskaa theiskaa added the feature New feature or request label Jul 27, 2021
@theiskaa theiskaa self-assigned this Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #30 (821de96) into develop (5c4083d) will increase coverage by 0.01%.
The diff coverage is 96.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    99.55%   99.56%   +0.01%     
===========================================
  Files            4        4              
  Lines          224      231       +7     
===========================================
+ Hits           223      230       +7     
  Misses           1        1              
Impacted Files Coverage Δ
lib/src/field_suggestion.dart 99.45% <96.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4083d...821de96. Read the comment docs.

@theiskaa theiskaa merged commit 5095a1d into develop Jul 27, 2021
@theiskaa theiskaa deleted the bugfix/state-refreshing branch July 27, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot refresh state
1 participant