Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py test is configurable and with coverage #103

Merged
merged 2 commits into from
Feb 24, 2015

Conversation

boyska
Copy link
Member

@boyska boyska commented Feb 23, 2015

the previous collector was difficult to configure, while now everything
can be done just editing the standard setup.cfg

Unit test coverage is a useful indicator when writing unit tests!

the previous collector was difficult to configure, while now everything
can be done just editing the standard setup.cfg
@boyska
Copy link
Member Author

boyska commented Feb 24, 2015

@ael-code you have some experience with setuptools, so you are a good candidate for reviewing this. Anyone else is welcome, of course!

@ael-code
Copy link
Member

probably I'm doing something wrong.

  • checked out the branch
  • python setup develop

test command is not installed

@boyska
Copy link
Member Author

boyska commented Feb 24, 2015

@ael-code what do you mean by test command is not installed ? It should be
python setup.py test. I'll clarify the docs.

@ael-code
Copy link
Member

sorry for the stupid question :) it works

@boyska
Copy link
Member Author

boyska commented Feb 24, 2015

That was not stupid, that was missing doc. Now the docs is not missing anymore ;)

ael-code added a commit that referenced this pull request Feb 24, 2015
setup.py test is configurable and with coverage
@ael-code ael-code merged commit dc044ad into insomnia-lab:master Feb 24, 2015
@boyska boyska deleted the nose-coverage branch February 24, 2015 17:47
@ael-code
Copy link
Member

maybe I merged too early.

I did not understand... looking at nose docs seems that python setup.py nosetests make the same thing you implemented without the need to introduce a custom command.

I'm confused.

@boyska
Copy link
Member Author

boyska commented Feb 24, 2015

On Tue, Feb 24, 2015 at 10:03:15AM -0800, ael wrote:

I did not understand... looking at nose docs seems that python setup.py nosetests make the same thing you implemented but without the need to introduce a custom command.

not exactly. That command is so few configurable that it is very
difficult to make it read setup.cfg. Reading many webpages (I'm now too
lazy to find them all) I discovered that even the nose project is not
liking that "bundled" command, and is suggesting the other approach
instead.

@ael-code
Copy link
Member

fine 👍

@ael-code ael-code mentioned this pull request Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants