Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flask dependecy #299

Merged
merged 1 commit into from
Jun 29, 2016
Merged

Conversation

ael-code
Copy link
Member

some minor changes to support the new flask version 0.11.1

importing stuff from flask.ext was deprecated and we were using it
only for babel

fixes #297

@boyska
Copy link
Member

boyska commented Jun 27, 2016

Is this new "style" also ok with old flask? I'd like to keep everything in debian stable supported (so maybe I should add an explicit test case in .travis.yml, right)

@ael-code
Copy link
Member Author

Is this new "style" also ok with old flask? I'd like to keep everything in debian stable supported (so maybe I should add an explicit test case in .travis.yml, right)

I've tested also with old Flask version. In any case it's better if we make travis run tests also with Flask 0.10.

@boyska
Copy link
Member

boyska commented Jun 27, 2016

ael:

Is this new "style" also ok with old flask? I'd like to keep everything in debian stable supported (so maybe I should add an explicit test case in .travis.yml, right)

I've tested also with old Flask version. In any case it's better if we make travis run tests also with Flask 0.10.

I am working on it; if I manage to do it soon, then merge that before
merging this. Otherwise, just merge this and I trust you to behave.

@boyska boyska mentioned this pull request Jun 27, 2016
@boyska
Copy link
Member

boyska commented Jun 27, 2016

#300 should do it. I also rebased this PR over #299 in a branch of mine to check if everything was ok, and it is. So you are free to rebase&merge, but please have a look at #300, too

some minor changes to support the new flask version 0.11.1

importing stuff from `flask.ext` was deprecated and we were using it
only for babel

fixes insomnia-lab#297
@ael-code ael-code merged commit e0d1ad5 into insomnia-lab:dev Jun 29, 2016
@ael-code ael-code deleted the deps_update_flask branch November 3, 2016 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel import method is deprecated
2 participants