Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.com/cenkalti/backoff for retries #308

Open
rjoleary opened this issue Jul 29, 2019 · 7 comments
Open

Use github.com/cenkalti/backoff for retries #308

rjoleary opened this issue Jul 29, 2019 · 7 comments

Comments

@rjoleary
Copy link

Use github.com/cenkalti/backoff to replace the backoff algorithm in #296.

The backoff package is well tested and gives the user more control over which backoff method and parameters to use.

@rjoleary
Copy link
Author

I can work on this.

@insomniacslk
Copy link
Owner

Thanks for working on this! On a phone now and can't remember what was wrong with the current retry system, are you addressing a particular problem that hit you?

@rjoleary
Copy link
Author

rjoleary commented Oct 7, 2019

There'd be two main benefits for using this library. First, it would give more control/options over how the backoff is performed (especially with the BackOff interface). Secondly, this backoff library is well tested.

@rjoleary
Copy link
Author

rjoleary commented Oct 7, 2019

It doesn't look like this repository has a vendor directory. How would you want to make the dependency on github.com/cenkalti/backoff ?

@hugelgupf
Copy link
Collaborator

I'd just make it without managing it, same as with u-root so far.

When u-root is ready we should go to modules?

@pmazzini
Copy link
Collaborator

I can work on this.

@rjoleary Are you looking at this?

@heinz-boehmer
Copy link

I'll take over this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants