Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are dns mandatory in GetNetConfFromPacketv4 #359

Closed
hexmiles opened this issue Feb 27, 2020 · 1 comment · Fixed by #424
Closed

Why are dns mandatory in GetNetConfFromPacketv4 #359

hexmiles opened this issue Feb 27, 2020 · 1 comment · Fixed by #424
Labels

Comments

@hexmiles
Copy link

I noticied that the function GetNetConfFromPacketv4 return an error if it dosen't find any dns server.
This cause the dhcp client to fail if the server dosen't return any dns server.

is there a reason or is this a bug?

i tried reading the dhcp specs and for what i understand dns are NOT mandatory.

@pmazzini
Copy link
Collaborator

We may have made it mandatory to be able to resolve URLs names in case one is returned as a boot file url.

I think the behavior can be changed. Feel free to put up a PR.

Otherwise, we can take a look at it later. Thanks for raising it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants