Split long replies if requested with -chunk

[insomniacslk]

Fixes #38

[insomniacslk]

@Syloq can you try this patch? More testing is coming

[codecov]

Codecov Report

Merging #45 into master will increase coverage by 3.23%.
The diff coverage is 48.78%.

@@            Coverage Diff            @@
##           master     #45      +/-   ##
=========================================
+ Coverage    2.89%   6.13%   +3.23%     
=========================================
  Files           6       7       +1     
  Lines         552     587      +35     
=========================================
+ Hits           16      36      +20     
- Misses        536     551      +15

Impacted Files	Coverage Δ
irc_context.go	0% <0%> (ø)	⬆️
irc_server.go	0% <0%> (ø)	⬆️
main.go	0% <0%> (ø)	⬆️
server.go	0% <0%> (ø)	⬆️
wordwrap.go	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6773b...4892bb9. Read the comment docs.

[Syloq]

I'm getting the same result as before the patch. I need to really debug the ZNC connection and see what is going on exactly. I see that you send the numeric 353 but ZNC does not like it and replies with a :"Received a too long line from the IRC server!" to the IRC client. I can't be exactly sure what is triggering the error. I'll look at it more tonight.

[insomniacslk]

Have you run it with -chunk 512 ?

[insomniacslk]

also CC @chex3, you have a lot of experience with large Slack teams :)

[Syloq]

Have you run it with -chunk 512 ?

Ugh, sorry I misunderstood what you did there. Yes, that appears to work as expected.

[insomniacslk]

it seems to fix some issues that I have on another large Slack team that I use for testing - now I don't have random surprises with the nick list anymore. I think it may be good to have this as default - maybe 1024 like most clients can deal with? Or 512 to make everyone happy at the cost of over-chunking?

[Syloq]

I'd go with 512 as the default and allow people to change it via the switch on the command line if they see fit. Seems like the best of both worlds.

[insomniacslk]

Alright, be it 512. Testing and merging soon

[Syloq]

So, I'm not sure if this is related. I have the chunking working properly now, but after running the irc-slack app for over a few hours with little to no activity I am no longer getting messages from slack. I see people sending them privately or in a channel via the slack web interface, but it isn't showing up in the client, nor in the log of the app itself.

I know this isn't overly helpful information. But I'm not sure if its related to this change or not.

[insomniacslk]

@Syloq do you see any relevant or weird message in the status bar? Or in the irc-slack logs?

[Syloq]

Sorry for the late reply. I think this was related to the other PR that came after this one. I was able to pull from master and try to replicate, but it hasn't had the same issue since. Thanks.