Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULL REQUEST] Fixed missing dependencies and formatting the code base #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kiraio-moe
Copy link

I actually wanted to talk about this in Issues but it wasn't there.

I came across the original project and see who's actively developing it at the time. And I see you have managed to understanding the code but facing difficulty to make this project in buildable state. So, I track back every dependencies this project used and somehow make it work!

I have tried to rebuild the login screen but failed to do it, because basically, no assets to working with. In the end, I surrender and making other project instead. I think it's worth mentioning this to you if you also have any will to continue developing this again.

It's been over a year since my last commit 💀, LOL...

Regards,
~ kiraio

The project is now in buildable state.

The missing dependencies are:
- DOTween (https://dotween.demigiant.com/)
- spine-unity (http://en.esotericsoftware.com/spine-unity-download)
- xLua (https://github.com/Tencent/xLua)

Signed-off-by: Bayu Satiyo <itsyuukunz@gmail.com>
@insomnyawolf
Copy link
Owner

I mean...
I am surprised, thank you for your effort however a diff of +122,472 −5,082 is hard to directly face.
If you could explain to me what you did i would be thankful because that's a lot of things to review for a pull request (yes, i am actually scared about the size of it) also feel free to contact me via direct message if you want, maybe we can talk about interesting things.

@kiraio-moe
Copy link
Author

kiraio-moe commented Oct 9, 2023

Not much of a work. Just formatting the entire C# code using CSharpier and installing these 3 library:
DOTween: Animation/Tweening library.
spine-unity: 2D skeletal animation library.
xLua: Lua programming in Unity.

My Discord username is kiraio.moe.

@insomnyawolf
Copy link
Owner

insomnyawolf commented Oct 10, 2023

I'd be thankful if you made a pull request with only the libraries part, we can deal with formatting later, i may even prepare a custom editor config so it's automatically done by the in-use editor (or investigate how can i do it with cli tools directly) but for a future.

Seriously, even if it's just formatting i prefer to review everything just in case and right now i am not in shape to take on 130k diffs...

I also added you on discord so we can coordinate there if you prefer.

Even then, thank you for the initiative <3

@kiraio-moe
Copy link
Author

kiraio-moe commented Oct 10, 2023

I'd be thankful if you made a pull request with only the libraries part, we can deal with formatting later, i may even prepare a custom editor config so it's automatically done by the in-use editor (or investigate how can i do it with cli tools directly) but for a future.

I'll revert it somehow.
Edit: I have reset it.

I also added you on discord so we can coordinate there if you prefer.

Ok, I have accepted the FR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants