Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ec2_traffic_mirror_target #500

Merged
merged 5 commits into from
Oct 28, 2021
Merged

aws_ec2_traffic_mirror_target #500

merged 5 commits into from
Oct 28, 2021

Conversation

Nirbhay1997
Copy link
Contributor

Signed-off-by: nirbhay1997 nkumar@progress.com

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Please fill box or appropriate ([x]) or mark N/A.

resource and unit test cases
e5a8375 
Signed-off-by: nirbhay1997 <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested a review from a team as a code owner July 26, 2021 10:47
@soumyo13 soumyo13 changed the title resource and unit test cases aws_ec2_traffic_mirror_target Jul 27, 2021
soumyo13
soumyo13 suggested changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the integration tests and the documentation.

soumyo13
soumyo13 suggested changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments.

@soumyo13 soumyo13 requested a review from a team August 9, 2021 06:31
@soumyo13
requested changes
c73c7e9 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
Copy link
Contributor

Please add the docs and integration tests.

@soumyo13
Merge branch 'main' of github.com:inspec/inspec-aws into nirbhay/Traf…
db65025 
…ficMirrorTarget
@soumyo13
resolved conflicts
f51c091 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@Nirbhay1997 Nirbhay1997 requested a review from a team as a code owner September 12, 2021 15:35
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13
Copy link
Contributor

Please add the integration and the terraform.

soumyo13
soumyo13 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumyo13
resolved conflicts
15edbfb 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 0c47b47 into main Oct 28, 2021
@soumyo13 soumyo13 deleted the nirbhay/TrafficMirrorTarget branch October 28, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyo13 soumyo13 soumyo13 approved these changes

Assignees

@Nirbhay1997 Nirbhay1997

Labels
Documentation Epic Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nirbhay1997 @soumyo13