Nirbhay/ Network Manager Device #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
soumyo13
suggested changes
Sep 1, 2021
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
IanMadd
force-pushed
the
Nirbhay/NetworkmanagerDevice
branch
from
7170080
to
0e24d6f
Compare
IanMadd
reviewed
Oct 4, 2021
| ### Ensure a zone is available. | ||
|
|
||
| describe aws_network_manager_devices do | ||
| its('aws_location.zone') { should include 'ZONE_NAME' } |
There was a problem hiding this comment.
Should this be aws_locations.zone?
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
IanMadd
approved these changes
Oct 6, 2021
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
IanMadd
approved these changes
Nov 23, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lintpasses