Adding attributes for ELB resource #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Joshi <rohit.prasad.joshi@sap.com>
libraries/aws_elb.rb
Outdated
| @@ -43,6 +43,10 @@ def initialize(opts = {}) | |||
| policies_in_use = resp.listener_descriptions.map(&:policy_names).flatten.uniq | |||
| @ssl_policies = @aws.elb_client.describe_load_balancer_policies(load_balancer_name: opts[:load_balancer_name]) | |||
| .policy_descriptions.select { |p| policies_in_use.include?(p.policy_name) } | |||
| @cross_zone_load_balancing = @aws.elb_client.describe_load_balancer_attributes(load_balancer_name: opts[:load_balancer_name]) | |||
There was a problem hiding this comment.
@Rohit1509 , Could we please do the n/w call to describe_load_balancer_attributes only once and set both the attributes using the attributes received ?
Also a couple of recommendations would be to
- lazy load this only when the method is called
- since this returns boolean flag, please try using matchers syntax for this ..
for example,
you can implement methods
cross_zone_load_balancing_enabled? & access_log_enabled?
which will be available in inspec controls as
it { should be_cross_zone_load_balancing_enabled }
it { should be_access_log_enabled }
Signed-off-by: Rohit Joshi <rohit.prasad.joshi@sap.com>
sathish-progress
added
CFT Support
Documentation
Version: Bump Minor
IanMadd
reviewed
Sep 24, 2021
docs/resources/aws_elb.md
Outdated
| |listeners | A collection of the listeners for the load balancer. | | ||
| |ssl_policies | A collection of the SSL Policies configured in-use for the load balancer (and their policy attributes). | | ||
| |protocols | A list of the protocols configured for the listeners of the load balancer. | | ||
| |cross\_zone\_load\_balancing\_enabled? | The cross zone load balancing status for ELB. | |
There was a problem hiding this comment.
Suggested change
| |cross\_zone\_load\_balancing\_enabled? | The cross zone load balancing status for ELB. | | |
| |cross\_zone\_load\_balancing\_enabled? | The cross-zone load balancing status for ELB. | |
IanMadd
reviewed
Sep 24, 2021
docs/resources/aws_elb.md
Outdated
|
|
||
| ## Examples | ||
|
|
||
| ##### Test that cross zone load balancing for ELB is enabled |
There was a problem hiding this comment.
Suggested change
| ##### Test that cross zone load balancing for ELB is enabled | |
| ##### Test that cross-zone load balancing for ELB is enabled |
IanMadd
reviewed
Sep 24, 2021
docs/resources/aws_elb.md
Outdated
| it { should be_cross_zone_load_balancing_enabled } | ||
| end | ||
|
|
||
| ##### Test that access log for ELB is enabled |
There was a problem hiding this comment.
Suggested change
| ##### Test that access log for ELB is enabled | |
| ##### Test that access logs for ELB are enabled |
added 2 commits
September 24, 2021 17:33
Signed-off-by: Rohit Joshi <rohit.prasad.joshi@sap.com>
…ohit1509/inspec-aws into adding_attributes_elb_resource
|
@IanMadd Can you please approve if the review is done? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Joshi rohit.prasad.joshi@sap.com
Description
Adding new attributes for ELB resource
Issues Resolved
None
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lintpasses