Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nirbhay/AmazonMQBroker #635

Merged
merged 15 commits into from
Oct 21, 2021
Merged

Nirbhay/AmazonMQBroker #635

merged 15 commits into from
Oct 21, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Sep 16, 2021

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners September 16, 2021 12:47
Nirbhay Kumar added 11 commits September 16, 2021 18:24
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
…hay/Resource

� Conflicts:
�	libraries/aws_backend.rb
�	test/integration/build/aws.tf
�	test/integration/build/outputs.tf
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nirbhay1997 Nirbhay1997 merged commit d9f95e4 into main Oct 21, 2021
@Nirbhay1997 Nirbhay1997 deleted the Nirbhay/Resource branch October 21, 2021 02:06
@ppradhan9 ppradhan9 linked an issue Oct 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::AmazonMQ::Broker
4 participants