Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing a attribute in cloudfront resource #648

Merged

Conversation

Rohit1509
Copy link

Signed-off-by: Rohit Joshi rohit.prasad.joshi@sap.com

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Rohit Joshi <rohit.prasad.joshi@sap.com>
@Rohit1509 Rohit1509 requested review from a team as code owners September 24, 2021 14:50
Signed-off-by: Rohit Joshi <rohit.prasad.joshi@sap.com>
Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohit1509
Copy link
Author

@sathish-progress that sonar cloud code analysis failed due to a resource in terraform which is totally unrelated to this PR

@sathish-progress sathish-progress added CFT Support Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. labels Sep 28, 2021
@Nirbhay1997
Copy link
Contributor

@sathish-progress that sonar cloud code analysis failed due to a resource in terraform which is totally unrelated to this PR
@Rohit1509 Marked the hotspot safe, As it was related to the integration test which we run manually and clean when we are done.

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@sathish-progress sathish-progress merged commit fa2d285 into inspec:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CFT Support Documentation Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants