-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Cloud front origin request policy #656
Conversation
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
…nto Nirbhay/OriginRequestPolicy
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
…o Nirbhay/OriginRequestPolicy
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
CloudFront is one word so it shouldn't have an underscore between "cloud" and "front" in the resource name. |
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Done with the changes , Please verify. |
@IanMadd Can you please verify ?? |
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Kudos, SonarCloud Quality Gate passed!
|
Description
It contains the singular resource of the above resource. It does not have a plural resource.
Issues Resolved
This is a new resource. There are no issues to be fixed.
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lint
passes