Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support Cloud Watch Dashboard #658

Merged
merged 9 commits into from
Oct 28, 2021
Merged

Added support Cloud Watch Dashboard #658

merged 9 commits into from
Oct 28, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Sep 30, 2021

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners September 30, 2021 11:59
@soumyo13 soumyo13 changed the title Added support Dashboard Added support Cloud Watch Dashboard Sep 30, 2021
soumyo13 and others added 4 commits September 30, 2021 17:58
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
@Nirbhay1997
Copy link
Contributor Author

@IanMadd @dkumaras Can you please approve, If all the changes are done.

Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 6b91af2 into main Oct 28, 2021
@soumyo13 soumyo13 deleted the NIrbhay/Dashboard branch October 28, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::CloudWatch::Dashboard
3 participants