Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soumyo/aws_cloudwatch_composite_alarm #676

Merged
merged 5 commits into from
Nov 21, 2021
Merged

soumyo/aws_cloudwatch_composite_alarm #676

merged 5 commits into from
Nov 21, 2021

Conversation

soumyo13
Copy link
Contributor

@soumyo13 soumyo13 commented Oct 3, 2021

Signed-off-by: Soumyodeep Karmakar soumyo.k13@gmail.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

@soumyo13
all singular and plural resource
e525183 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 self-assigned this Oct 3, 2021
@soumyo13 soumyo13 requested review from a team as code owners October 3, 2021 18:28
@soumyo13 soumyo13 linked an issue Oct 3, 2021 that may be closed by this pull request
AWS::CloudWatch::CompositeAlarm #580
Closed
@soumyo13
updated
b834e0d 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
updated
242e09b 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 changed the title soumyo/aws_cloud_watch_composite_alarm soumyo/aws_cloudwatch_composite_alarm Oct 8, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

Nirbhay1997
Nirbhay1997 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanMadd
Docs edits
d4b9536 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@soumyo13
resolved conflicts
3687835 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

@soumyo13 soumyo13 merged commit b8366a3 into main Nov 21, 2021
@soumyo13 soumyo13 deleted the soumyo/aws_cloud_watch_composite_alarm branch November 21, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@Nirbhay1997 Nirbhay1997 Nirbhay1997 approved these changes

Assignees

@soumyo13 soumyo13

Labels
2021_PQ4 Documentation Epic Feature Request ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::CloudWatch::CompositeAlarm
4 participants
@soumyo13 @IanMadd @Nirbhay1997 @kagarmoe