Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nirbhay/AWS CloudFront Public Key resource #682

Merged
merged 16 commits into from
Nov 21, 2021
Merged

Nirbhay/AWS CloudFront Public Key resource #682

merged 16 commits into from
Nov 21, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Oct 11, 2021 •
edited by soumyo13
Loading

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

singular and plural resource
8bfe734 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners October 11, 2021 19:02
@Nirbhay1997 Nirbhay1997 self-assigned this Oct 11, 2021
@Nirbhay1997 Nirbhay1997 marked this pull request as draft October 11, 2021 19:02
@soumyo13 soumyo13 added the wip WORK in Progress label Oct 12, 2021
@soumyo13 soumyo13 linked an issue Oct 12, 2021 that may be closed by this pull request
AWS::CloudFront::PublicKey #576
Closed
Nirbhay Kumar and others added 5 commits October 14, 2021 08:07
unit test
b5aa860 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
unit test
29951ab 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997
Delete aws_cloudfrony_public_keys.rb
cb14d92
@Nirbhay1997
Delete aws_cloudfrony_public_key.rb
d0ec019
integration and docs
7a01044 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 marked this pull request as ready for review October 14, 2021 09:24
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Nirbhay Kumar and others added 3 commits October 14, 2021 14:56
integration and docs
9780c72 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Merge remote-tracking branch 'origin/PublicKey' into PublicKey
06452c9
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_cloudfront_public_key_test.rb
907711f 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
soumyo13
soumyo13 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumyo13
updated
0d6e4e8 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IanMadd
Docs edits
69ac209 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@soumyo13
resolved conflicts
30974f8 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit c3ff70e into main Nov 21, 2021
@soumyo13 soumyo13 deleted the PublicKey branch November 21, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@soumyo13 soumyo13 soumyo13 approved these changes

Assignees

@Nirbhay1997 Nirbhay1997

Labels
2021_PQ4 Documentation Feature Request ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::CloudFront::PublicKey
4 participants
@Nirbhay1997 @IanMadd @soumyo13 @kagarmoe