Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nirbhay/EC2-Carrier-Gateway #686

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Nirbhay/EC2-Carrier-Gateway #686

merged 5 commits into from
Nov 10, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Oct 12, 2021

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource. This does not contain terraform.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners October 12, 2021 08:20
@Nirbhay1997 Nirbhay1997 self-assigned this Oct 12, 2021
@soumyo13 soumyo13 linked an issue Oct 12, 2021 that may be closed by this pull request
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@soumyo13 soumyo13 added the wip WORK in Progress label Oct 14, 2021
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 80876f3 into main Nov 10, 2021
@soumyo13 soumyo13 deleted the NIrbhay/AWS_EC2_CarrierGateway branch November 10, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::EC2::CarrierGateway
3 participants