Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIRBHAY/aws_ec2_client_vpn_route #716

Merged
merged 21 commits into from
Nov 23, 2021
Merged

NIRBHAY/aws_ec2_client_vpn_route #716

merged 21 commits into from
Nov 23, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Oct 27, 2021 •
edited by soumyo13
Loading

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

added singular and plual resource
7022869 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners October 27, 2021 20:51
@Nirbhay1997 Nirbhay1997 changed the title added singular and plual resource NIRBHAY/aws_ec2_client_vpn_route Oct 27, 2021
soumyo13
soumyo13 reviewed Oct 28, 2021
View reviewed changes
libraries/aws_ec2_client_vpn_route.rb Outdated Show resolved Hide resolved
libraries/aws_ec2_client_vpn_route.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_ec2_client_vpn_route_test.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_ec2_client_vpn_route_test.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_ec2_client_vpn_route_test.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_ec2_client_vpn_routes_test.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_ec2_client_vpn_routes_test.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_ec2_client_vpn_routes_test.rb Outdated Show resolved Hide resolved
libraries/aws_ec2_client_vpn_route.rb Outdated Show resolved Hide resolved
libraries/aws_ec2_client_vpn_route.rb Outdated Show resolved Hide resolved
Nirbhay1997 and others added 12 commits October 28, 2021 10:11
@Nirbhay1997 @soumyo13
Update libraries/aws_ec2_client_vpn_route.rb
c03e9c3 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update libraries/aws_ec2_client_vpn_route.rb
084ce41 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update libraries/aws_ec2_client_vpn_route.rb
c451774 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update libraries/aws_ec2_client_vpn_route.rb
84cebcf 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_route_test.rb
f94310e 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_route_test.rb
bd9c683 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_route_test.rb
8ecf89e 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_route_test.rb
7d78298 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_route_test.rb
925acf7 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_route_test.rb
9d070d6 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_route_test.rb
0fc34be 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_routes_test.rb
c891c4a 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@soumyo13 soumyo13 linked an issue Oct 28, 2021 that may be closed by this pull request
AWS::EC2::ClientVpnRoute #591
Closed
Nirbhay Kumar and others added 4 commits October 28, 2021 16:14
added inegration tests
0ffdfa1 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_routes_test.rb
67fa9f6 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_routes_test.rb
7b18569 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@Nirbhay1997 @soumyo13
Update test/unit/resources/aws_ec2_client_vpn_routes_test.rb
e039aad 
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@IanMadd
Docs edits
748a8ab 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit ca4c777 into main Nov 23, 2021
@soumyo13 soumyo13 deleted the NIRBHAY/aws_ec2_client_vpn_route branch November 23, 2021 05:33
@soumyo13 soumyo13 restored the NIRBHAY/aws_ec2_client_vpn_route branch November 23, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyo13 soumyo13 soumyo13 approved these changes

Assignees

@Nirbhay1997 Nirbhay1997

Labels
2021_PQ4 Documentation Epic Feature Request ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::EC2::ClientVpnRoute
4 participants
@Nirbhay1997 @soumyo13 @kagarmoe @IanMadd