Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nirbhay/ClientVpnTargetNetworkAssociation #746

Merged
merged 20 commits into from
Oct 29, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Oct 28, 2021

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners October 28, 2021 03:55
@soumyo13 soumyo13 changed the title added singular and plural resource Nirbhay/ClientVpnTargetNetworkAssociation Oct 28, 2021
@soumyo13 soumyo13 linked an issue Oct 28, 2021 that may be closed by this pull request
@soumyo13 soumyo13 removed a link to an issue Oct 28, 2021
@soumyo13 soumyo13 linked an issue Oct 28, 2021 that may be closed by this pull request
Nirbhay Kumar and others added 10 commits October 28, 2021 15:47
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
…ions_test.rb

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
…ions_test.rb

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
…ions_test.rb

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
…ions_test.rb

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
…ions_test.rb

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
…ion_test.rb

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit c3896e2 into main Oct 29, 2021
@soumyo13 soumyo13 deleted the Nirbhay/ClientVpnTargetNetworkAssociation branch October 29, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::EC2::ClientVpnTargetNetworkAssociation
3 participants