Added support for checking last_status for a config recorder #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
|
@varunsharma5 : Please don't add ReadyForDoc & Documentation label till Inspec-cloud-dev doesn't approve it. |
soumyo13
reviewed
Nov 10, 2021
There was a problem hiding this comment.
Please check my comments.
Other Comments:
-
Please update the docs link on line no 41 to "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-config-configurationrecorder.html".
-
Please update the text of line no 41 from "[AWS documentation on Configuration]" to "[AWS documentation on AWS Config Configuration Recorder]".
-
Do we need the plural resource also or singular resource is fine?
Incorporated the review comments Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
…s into aws_config_delivery_log Signed-off-by: Varun Sharma <varun.sharma@progress.com>
soumyo13
approved these changes
Nov 10, 2021
soumyo13
reviewed
Nov 10, 2021
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
soumyo13
approved these changes
Nov 10, 2021
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
IanMadd
force-pushed
the
aws_config_delivery_log
branch
from
1718707
to
aed7a5b
Compare
IanMadd
approved these changes
Nov 10, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Varun Sharma varun.sharma@progress.com
Description
Added support for checking last_status for a config recorder
Issues Resolved
#749
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lintpasses