Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soumyo/aws_cloudformation_template #753

Merged
merged 9 commits into from
Nov 15, 2021
Merged

Conversation

soumyo13
Copy link
Contributor

@soumyo13 soumyo13 commented Nov 9, 2021

Signed-off-by: Soumyodeep Karmakar soumyo.k13@gmail.com

Description

It contains all the singular resources of the above resource. As we don't have an API we don't have a plural resource. We are testing this resource manually.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
50.3% 50.3% Duplication

@soumyo13 soumyo13 merged commit 7ef794f into main Nov 15, 2021
@soumyo13 soumyo13 deleted the soumyo/aws_cloudformation_template branch November 15, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS CloudFormation Template should not contain globally open resources
3 participants