Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for AWS EMR Cluster resource #758

Merged
merged 32 commits into from
Nov 19, 2021

Conversation

varunsharma5
Copy link
Collaborator

Signed-off-by: Varun Sharma varun.sharma@progress.com

Description

Adding support for AWS::EMR::Cluster.

Issues Resolved

#757

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Varun Sharma <varun.sharma@progress.com>
@varunsharma5 varunsharma5 requested review from a team as code owners November 11, 2021 07:51
@varunsharma5 varunsharma5 linked an issue Nov 11, 2021 that may be closed by this pull request
@varunsharma5 varunsharma5 self-assigned this Nov 11, 2021
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my comments.

libraries/aws_emr_cluster.rb Outdated Show resolved Hide resolved
libraries/aws_emr_clusters.rb Outdated Show resolved Hide resolved
test/integration/build/aws.tf Outdated Show resolved Hide resolved
test/integration/verify/controls/aws_emr_cluster.rb Outdated Show resolved Hide resolved
docs/resources/aws_emr_cluster.md Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
libraries/aws_emr_cluster.rb Outdated Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_cluster.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_cluster.md Show resolved Hide resolved
docs/resources/aws_emr_cluster.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_cluster.md Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_clusters.md Outdated Show resolved Hide resolved
@soumyo13 soumyo13 changed the title Added code for AWS EMR resource Added support for AWS EMR Cluster resource Nov 15, 2021
varunsharma5 and others added 13 commits November 15, 2021 12:53
accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

varunsharma5 and others added 3 commits November 15, 2021 13:02
Accepted suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepted suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepted suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
varunsharma5 and others added 6 commits November 15, 2021 13:31
Accepted suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepted suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepted suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
Accepting suggested changes

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
…mation from AWS EMR. For EMR's security configuration, there will be a separate resource pack

Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review comments.

docs/resources/aws_emr_cluster.md Outdated Show resolved Hide resolved
docs/resources/aws_emr_cluster.md Outdated Show resolved Hide resolved
libraries/aws_emr_clusters.rb Outdated Show resolved Hide resolved
test/integration/verify/controls/aws_emr_cluster.rb Outdated Show resolved Hide resolved
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
…spec-aws into varunsharma5/aws_emr_cluster_1
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nirbhay1997 Nirbhay1997 merged commit d325d98 into main Nov 19, 2021
@Nirbhay1997 Nirbhay1997 deleted the varunsharma5/aws_emr_cluster_1 branch November 19, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::EMR::Cluster
5 participants