Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for AWS::EMR::SecurityConfiguration. #766

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Added support for AWS::EMR::SecurityConfiguration. #766

merged 5 commits into from
Nov 19, 2021

Conversation

varunsharma5
Copy link
Collaborator

@varunsharma5 varunsharma5 commented Nov 17, 2021 •
edited
Loading

Signed-off-by: Varun Sharma varun.sharma@progress.com

Description

Added support for AWS::EMR::SecurityConfiguration

Issues Resolved

#765

Check List

Please fill box or appropriate ([x]) or mark N/A.

@eagleeye-externalVarumS
Added support for AWS::EMR::SecurityConfiguration. Doc pending
f2ed8d9 
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
@varunsharma5 varunsharma5 requested a review from a team as a code owner November 17, 2021 05:53
@varunsharma5 varunsharma5 self-assigned this Nov 17, 2021
@varunsharma5 varunsharma5 linked an issue Nov 17, 2021 that may be closed by this pull request
AWS::EMR::SecurityConfiguration support #765
Closed
soumyo13
soumyo13 suggested changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the review comments and also add the documentation files.

test/integration/verify/controls/aws_emr_security_configuration.rb Outdated Show resolved Hide resolved
@eagleeye-externalVarumS
Added documentation, modified as per review comments
8bd914a 
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
@varunsharma5 varunsharma5 requested a review from a team as a code owner November 17, 2021 13:06
@Nirbhay1997 Nirbhay1997 changed the title Added support for AWS::EMR::SecurityConfiguration. Doc pending Added support for AWS::EMR::SecurityConfiguration. Nov 18, 2021
@eagleeye-externalVarumS
Adding emr dependency in aws_backend.rb
7b14136 
Signed-off-by: Varun Sharma <varun.sharma@progress.com>
@IanMadd
Docs edits
92f7bb5 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Resloved conflicts
6326eb7 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.7% 8.7% Duplication

@Nirbhay1997 Nirbhay1997 merged commit b83df3a into main Nov 19, 2021
@Nirbhay1997 Nirbhay1997 deleted the varunsharma5/aws_emr_sec_config branch November 19, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@Nirbhay1997 Nirbhay1997 Nirbhay1997 approved these changes

@soumyo13 soumyo13 soumyo13 approved these changes

Assignees

@varunsharma5 varunsharma5

Labels
2021_PQ4 CFT Support Documentation Feature Request ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::EMR::SecurityConfiguration support
5 participants
@varunsharma5 @IanMadd @Nirbhay1997 @soumyo13 @eagleeye-externalVarumS