Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nitbhay/aws_rds_global_cluster #780

Merged
merged 21 commits into from
Dec 5, 2021
Merged

nitbhay/aws_rds_global_cluster #780

merged 21 commits into from
Dec 5, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Nov 24, 2021 •
edited by soumyo13
Loading

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

added resource and unit tests
4ce71d7 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners November 24, 2021 02:19
soumyo13
soumyo13 suggested changes Nov 24, 2021
View reviewed changes
libraries/aws_rds_global_cluster.rb Outdated Show resolved Hide resolved
libraries/aws_rds_global_cluster.rb Outdated Show resolved Hide resolved
libraries/aws_rds_global_cluster.rb Outdated Show resolved Hide resolved
@soumyo13 soumyo13 linked an issue Nov 24, 2021 that may be closed by this pull request
AWS::RDS::GlobalCluster #742
Closed
@soumyo13 soumyo13 changed the title Added Support to Audit RDS Global Clusters nitbhay/AWS_RDS_GlobalCluster Nov 25, 2021
@soumyo13 soumyo13 changed the title nitbhay/AWS_RDS_GlobalCluster nitbhay/aws_rds_global_cluster Nov 25, 2021
Nirbhay Kumar added 2 commits November 25, 2021 14:30
updated docs and tf
8f7705a 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Merge remote-tracking branch 'origin/nitbhay/AWS_RDS_GlobalCluster' i…
8e997aa 
…nto nitbhay/AWS_RDS_GlobalCluster
@soumyo13
updated docs
df0200a 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@IanMadd
Docs edits
436ab89 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@soumyo13
resolved conflicts
5558ea7 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit e03e3fc into main Dec 5, 2021
@soumyo13 soumyo13 deleted the nitbhay/AWS_RDS_GlobalCluster branch December 5, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@soumyo13 soumyo13 soumyo13 approved these changes

Assignees

@Nirbhay1997 Nirbhay1997

Labels
2021_PQ4 Documentation Epic Feature Request ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::RDS::GlobalCluster
3 participants
@Nirbhay1997 @IanMadd @soumyo13