Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nirbhay/aws_s3_bucket_policy #783

Merged
merged 25 commits into from
Dec 15, 2021
Merged

nirbhay/aws_s3_bucket_policy #783

merged 25 commits into from
Dec 15, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Nov 24, 2021

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners November 24, 2021 19:08
@Nirbhay1997 Nirbhay1997 changed the title added resourcce and test Nirbhay/Bucket_policy Nov 25, 2021
soumyo13 and others added 5 commits November 25, 2021 13:08
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 changed the title Nirbhay/Bucket_policy nirbhay/aws_s3_bucket_policy Nov 25, 2021
@soumyo13 soumyo13 linked an issue Nov 25, 2021 that may be closed by this pull request
Nirbhay Kumar added 6 commits November 25, 2021 16:32
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
docs/resources/aws_s3_bucket_policy.md Outdated Show resolved Hide resolved
docs/resources/aws_s3_bucket_policy.md Outdated Show resolved Hide resolved
libraries/aws_s3_bucket_policy.rb Outdated Show resolved Hide resolved
libraries/aws_s3_bucket_policy.rb Outdated Show resolved Hide resolved
test/integration/verify/controls/aws_s3_bucket_policy.rb Outdated Show resolved Hide resolved
@soumyo13
Copy link
Contributor

soumyo13 commented Dec 5, 2021

Here I have added the BucketPolicy in the Readme.md file. No need of creating a separate PR for this. @Nirbhay1997

Nirbhay Kumar and others added 3 commits December 14, 2021 12:26
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 7ba5194 into main Dec 15, 2021
@soumyo13 soumyo13 deleted the NIrbhay/AWS_S3_Bucket_Policy branch December 15, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::S3::BucketPolicy
3 participants