Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nirbhay/aws_waf_rule #802

Merged
merged 12 commits into from
Dec 15, 2021
Merged

nirbhay/aws_waf_rule #802

merged 12 commits into from
Dec 15, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Dec 11, 2021 •
edited by soumyo13
Loading

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

resource and unit test cases
fabcec7 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners December 11, 2021 20:37
soumyo13
soumyo13 suggested changes Dec 13, 2021
View reviewed changes
libraries/aws_waf_rule.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_waf_rule_test.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_waf_rule_test.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_waf_rules_test.rb Show resolved Hide resolved
@soumyo13 soumyo13 linked an issue Dec 13, 2021 that may be closed by this pull request
AWS::WAF::Rule #787
Closed
@soumyo13 soumyo13 changed the title AWS_WAF_RULE nirbhay/aws_waf_rule Dec 13, 2021
Nirbhay Kumar added 3 commits December 13, 2021 10:06
integration test
4177be1 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
updated_doc
507bb19 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
updated_doc
1cf9953 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@IanMadd
Docs edits
88e4765 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 1067f85 into main Dec 15, 2021
@soumyo13 soumyo13 deleted the AWS_WAF_Rule branch December 15, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@soumyo13 soumyo13 soumyo13 approved these changes

Assignees

@Nirbhay1997 Nirbhay1997

Labels
2021_PQ4 Documentation Epic Feature Request ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::WAF::Rule
3 participants
@Nirbhay1997 @IanMadd @soumyo13