Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nirbhay/aws_waf_ip_set #804

Merged
merged 19 commits into from
Dec 27, 2021
Merged

nirbhay/aws_waf_ip_set #804

merged 19 commits into from
Dec 27, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Dec 12, 2021 •
edited by soumyo13
Loading

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Nirbhay Kumar added 2 commits December 12, 2021 11:07
resource
ab3d09c 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
test-fix
4ab5b5c 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners December 12, 2021 11:24
integration test
cfb93fa 
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
soumyo13
soumyo13 suggested changes Dec 13, 2021
View reviewed changes
libraries/aws_waf_ip_set.rb Outdated Show resolved Hide resolved
libraries/aws_waf_ip_set.rb Outdated Show resolved Hide resolved
test/unit/resources/aws_waf_ip_set_test.rb Outdated Show resolved Hide resolved
@soumyo13 soumyo13 linked an issue Dec 13, 2021 that may be closed by this pull request
AWS::WAF::IPSet #786
Closed
@soumyo13 soumyo13 changed the title Aws WAF IP Set nirbhay/aws_waf_ip_set Dec 13, 2021
@soumyo13
added docs and updated the singular resource
16e876f 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13
added the integration tests
a88ae9f 
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
soumyo13
soumyo13 reviewed Dec 14, 2021
View reviewed changes
docs/resources/aws_waf_ip_set.md Outdated Show resolved Hide resolved
docs/resources/aws_waf_ip_set.md Outdated Show resolved Hide resolved
docs/resources/aws_waf_ip_sets.md Outdated Show resolved Hide resolved
docs/resources/aws_waf_ip_sets.md Outdated Show resolved Hide resolved
soumyo13 and others added 2 commits December 14, 2021 16:04
@soumyo13
Merge branch 'main' into AWS_WAF_IPSet
a9ac1e5
@IanMadd
Docs edits
b941452 
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 75fad4e into main Dec 27, 2021
@soumyo13 soumyo13 deleted the AWS_WAF_IPSet branch December 27, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@soumyo13 soumyo13 soumyo13 approved these changes

Assignees

@Nirbhay1997 Nirbhay1997

Labels
2021_PQ4 Documentation Epic Feature Request ReadyForDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::WAF::IPSet
3 participants
@Nirbhay1997 @IanMadd @soumyo13