Add attributes s3_key_prefix & organization_trail to aws_cloudtrail_trail resource

[rezen]

Description

Added attributes s3_key_prefix & organization_trail to aws_cloudtrail_trail resource

Check List

Please fill box or appropriate ([x]) or mark N/A.

• New functionality includes integration tests/controls
• N/A New Terraform resources
• Documentation provided or updated for resources
• All Integration Tests pass
• All Unit Tests pass
• rake lint passes
• All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

[netlify]

✅ Deploy Preview for inspec-aws canceled.

Name	Link
🔨 Latest commit	a42b16a
🔍 Latest deploy log	https://app.netlify.com/sites/inspec-aws/deploys/64028b6ab743da000874364a

[soumyo13]

@rezen Please check DCO is failing. Please commit the code with the following command with the following command

git commit -s -m "<reason-of-the-commit>"

[soumyo13]

Can we remove this? We dont require the alias. is_organization_trail looks good.

[soumyo13]

I tried to run with the control with organization_trail, it failed. It is not taking the alias.

Code that I have used is

control "test1" do
describe aws_cloudtrail_trail('testbucketname') do
its("is_organization_trail") { should eq false }
its("organization_trail") { should eq false }
its("organization_trail") { should eq "" }
end
end

output

× test1: CloudTrail testbucketname (2 failed)
✔ CloudTrail testbucketname is_organization_trail is expected to eq false
× CloudTrail testbucketname organization_trail is expected to eq false

 expected: false
      got: #<#<Class:0x000000010fc0d860>::NullResponse:0x000000010fa83198>

 (compared using ==)
 ×  CloudTrail testbucketname organization_trail is expected to eq false

 expected: false
      got: #<#<Class:0x000000010fc0d860>::NullResponse:0x000000010fa83198>

 (compared using ==)

[soumyo13]

@rezen Please check this.

[clintoncwolfe]

Try it { should be_organizational_trail } . It makes good English.

[soumyo13]

it { should be_organizational_trail }

This is working fine. So we can merge this PR.

[rezen]

@soumyo13 I did the sign off, I think it's unhappy because I didn't include my email in Signed-off-by: Andres Hermosilla <>

[soumyo13]

@rezen Please add the email in the sign off. I think that will work and DCO will pass.

[rezen]

@soumyo13 Fixed the DCO 👍

[soumyo13]

LGTM