Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

CHEF-3704 Modify help for local licensing service mode and other distros #59

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

Nik08
Copy link
Contributor

@Nik08 Nik08 commented Jun 21, 2023

Description

Modify help for local licensing service mode and other distros

  1. To update the description for license add and license list commands, about their applicability in local licensing service mode.
  2. To hide licensing information, and licensing argument options (ex: --chef-license-key) for CINC and other distros.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 Nik08 requested a review from a team as a code owner June 21, 2023 12:12
@Nik08 Nik08 requested review from Vasu1105 and ahasunos June 21, 2023 12:12

inspec license add: This command helps users to generate or add an additional license
inspec license add: This command helps users to generate or add an additional license (not applicable to local licensing service)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to document I am adding this here. We are describing the local licensing environment in some of the messages as airgap Ref : https://github.com/chef/chef-licensing/pull/121/files#diff-cd5092606f7cfac997e290a1889646f6c98710e9126b8380362700c0396cec50R66 . This naming should be same everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, at this point we are going ahead with the difference of naming conventions here. So not making same everywhere. Correct me, if this is not what we concluded in our meeting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what discussed.

@clintoncwolfe
Copy link
Contributor

Verify failing due to UUID generation issue which is unrelated. Merging.

@clintoncwolfe clintoncwolfe merged commit f031999 into inspec-6 Jun 22, 2023
3 of 4 checks passed
@clintoncwolfe clintoncwolfe deleted the nm/help-license-key-add branch June 22, 2023 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants