Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

Configure to use Inspec::Log in Chef Licensing #67

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

ahasunos
Copy link
Contributor

@ahasunos ahasunos commented Jun 23, 2023

Description

This PR configures the Chef Licensing system to use the Inspec::Log to be able to use the InSpec's logging functionality.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos changed the title [Do Not Merge] Trial Test 2 Configure to use InSpec::Log in Chef Licensing Jun 26, 2023
@ahasunos ahasunos changed the title Configure to use InSpec::Log in Chef Licensing Configure to use Inspec::Log in Chef Licensing Jun 26, 2023
@clintoncwolfe
Copy link
Contributor

This is an improvement, and "how it is supposed to work". The problem now is that InSpec is configuring the ChefLicensing system with a default InSpec::Log, then processing the CLI options (and recognising that it should reconfigure the logger to be in debug mode), and the we get debug level too late to get early licensing API calls.

I'm tempted to merge this because it is an improvement in diagnostics, but we really need a better approach to the sequencing problem.

@clintoncwolfe
Copy link
Contributor

Good > perfect, some debugging better than none.

@clintoncwolfe clintoncwolfe merged commit 20a4586 into inspec-6 Jul 6, 2023
3 of 4 checks passed
@clintoncwolfe clintoncwolfe deleted the ss/test-verify-pipeline branch July 6, 2023 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants