Merge pull request #991 from jeremymv2/cmp_treat_0_as_integer

cmp not treating 0 as integer only as string
inspec · Aug 30, 2016 · 4673dfd · 4673dfd
2 parents efec631 + 3822b8e
commit 4673dfd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/matchers/matchers.rb b/lib/matchers/matchers.rb
@@ -232,7 +232,7 @@
 RSpec::Matchers.define :cmp do |first_expected|
 
   def integer?(value)
-    !(value =~ /\A[1-9]\d*\Z/).nil?
+    !(value =~ /\A0+\Z|\A[1-9]\d*\Z/).nil?
   end
 
   def float?(value)

diff --git a/test/integration/default/cmp_matcher_spec.rb b/test/integration/default/cmp_matcher_spec.rb
@@ -112,4 +112,14 @@
     it { should cmp 'False' }
     it { should cmp false }
   end
+
+  describe 0 do
+    it { should cmp 0 }
+    it { should cmp 00 }
+    it { should cmp '0' }
+    it { should cmp '00' }
+    it { should_not cmp 1 }
+    it { should_not cmp '01' }
+  end
+
 end