Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add platform info to json formatter #1792

Merged
merged 1 commit into from
May 10, 2017
Merged

add platform info to json formatter #1792

merged 1 commit into from
May 10, 2017

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented May 10, 2017

As part of #1661

@arlimus
add platform info to json formatter
1692687 
As part of #1661

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@arlimus arlimus self-assigned this May 10, 2017
@arlimus arlimus modified the milestone: InSpec 2.0 May 10, 2017
chris-rock
chris-rock approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @arlimus

alexpop
alexpop approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@alexpop alexpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  "platform": {
    "name": "centos",
    "release": "6.8"
  }

  "platform": {
    "name": "mac_os_x",
    "release": "10.11.6"
  }

👍

@chris-rock chris-rock merged commit ac5eb7a into master May 10, 2017
@chris-rock chris-rock deleted the dr/platform-info branch May 10, 2017 08:51
@adamleff adamleff added the Type: Enhancement Improves an existing feature label May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpop alexpop alexpop approved these changes

@chris-rock chris-rock chris-rock approved these changes

@adamleff adamleff Awaiting requested review from adamleff

Assignees

@arlimus arlimus

Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arlimus @alexpop @chris-rock @adamleff