New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matcher for less-restrictive comparison #318
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9f0755b
add new `cmp` matcher that eases the comparison for values
chris-rock c461ffe
add integration test for compare matcher
chris-rock 82b63bb
update documentation for `auditd_conf` and `sshd_config`
chris-rock 53728ee
lint fix
chris-rock 31f8863
update failure message for `cmp` matcher
chris-rock 52cd0b3
update style of `float?` detection
chris-rock 1ce1f26
update docs for auditd_conf
chris-rock 0185751
lint exception
chris-rock File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
test/integration/test/integration/default/compare_matcher_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# encoding: utf-8 | ||
|
||
# uses the `cmp` matcher instead of the eq matcher | ||
describe sshd_config do | ||
its('Port') { should eq '22' } | ||
its('Port') { should_not eq 22 } | ||
|
||
its('Port') { should cmp '22' } | ||
its('Port') { should cmp 22 } | ||
its('Port') { should cmp 22.0 } | ||
its('Port') { should_not cmp 22.1 } | ||
|
||
its('LogLevel') { should eq 'INFO' } | ||
its('LogLevel') { should_not eq 'info'} | ||
|
||
its('LogLevel') { should cmp 'INFO' } | ||
its('LogLevel') { should cmp 'info' } | ||
its('LogLevel') { should cmp 'InfO' } | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we establish cmp as the default matcher instead of eq for auditd_conf? Since the resource would be perfect for that! (i.e. just swap with eq + love the explanation!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a great idea. I updated the docs.