Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a merged json report for A2 #3261

Merged
merged 4 commits into from Aug 3, 2018
Merged

Add a merged json report for A2 #3261

merged 4 commits into from Aug 3, 2018

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Jul 30, 2018

This PR creates a new json report which merges the profiles upstream into their parents. This will offload the work from A2 and allow us to send a smaller report up.

Fixes #3183

Signed-off-by: Jared Quick <jquick@chef.io>
@jquick jquick added the Type: Enhancement Improves an existing feature label Jul 30, 2018
@aaronlippold
Copy link
Collaborator

@jquick which use case are we hitting here? Just so I can go test in the right context?

@jquick
Copy link
Contributor Author

jquick commented Jul 30, 2018

Basically this report combines all child profiles into their parents which is what A2 requires for its reporting structure. So instead of having:

report a
report b
report c -> child of b
report d -> child of c

We would now have

report a
report b (with all results/controls/depends from c/d populated)

@aaronlippold
Copy link
Collaborator

aaronlippold commented Jul 30, 2018 via email

@jquick
Copy link
Contributor Author

jquick commented Jul 30, 2018

Yes, in a normal case you are correct. You would only have multiple top level profiles if you are running multiple profiles at the same time.

Signed-off-by: Jared Quick <jquick@chef.io>
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jquick

@chris-rock chris-rock merged commit 73a4013 into master Aug 3, 2018
@chris-rock chris-rock deleted the jq/merge_a2_report branch August 3, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants