New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a merged json report for A2 #3261
Conversation
Signed-off-by: Jared Quick <jquick@chef.io>
Signed-off-by: Jared Quick <jquick@chef.io>
Signed-off-by: Jared Quick <jquick@chef.io>
@jquick which use case are we hitting here? Just so I can go test in the right context? |
Basically this report combines all child profiles into their parents which is what A2 requires for its reporting structure. So instead of having:
We would now have
|
Hi,
Sounds good, what's the value of having `report a` in this case? For the
inherited profile which is a daisy-chain of profiles which creates an
`overlay` of an app/system stack - would `report b` not be what we really
want in the end? So my basic question as an auditor would be can we
streamline the data even more and drop `report a`? I must be missing a
detail in here :)
Thanks,
Aaron
--------
Aaron Lippold
lippold@gmail.com
260-255-4779
twitter/aim/yahoo,etc.
'aaronlippold'
…On Mon, Jul 30, 2018 at 10:57 AM Jared Quick ***@***.***> wrote:
Basically this report combines all child profiles into their parents which
is what A2 requires for its reporting structure. So instead of having:
report a
report b
report c -> child of b
report d -> child of c
We would now have
report a
report b (with all results/controls from c/d populated)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3261 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABauaPcMlOuju_29YOn5qQW6EHXAf5v2ks5uLx7pgaJpZM4VmfuM>
.
|
Yes, in a normal case you are correct. You would only have multiple top level profiles if you are running multiple profiles at the same time. |
Signed-off-by: Jared Quick <jquick@chef.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jquick
This PR creates a new json report which merges the profiles upstream into their parents. This will offload the work from A2 and allow us to send a smaller report up.
Fixes #3183