Add platforms schema command #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/schema_train_platforms
branch
from
2b9ffd8
to
2dc0f2e
Compare
Signed-off-by: Jared Quick <jquick@chef.io>
Signed-off-by: Jared Quick <jquick@chef.io>
jerryaldrichiii
previously requested changes
Sep 13, 2018
Gemfile
Outdated
| @@ -2,6 +2,8 @@ | |||
| source 'https://rubygems.org' | |||
| gemspec name: 'inspec' | |||
|
|
|||
| gem 'train', :git => 'https://github.com/inspec/train.git', :branch => 'jq/add_platforms_export' | |||
There was a problem hiding this comment.
I think we can remove this now.
There was a problem hiding this comment.
Not till train gem is pushed out.
inspec.gemspec
Outdated
| @@ -26,7 +26,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.required_ruby_version = '>= 2.3' | |||
|
|
|||
| spec.add_dependency 'train', '~> 1.4', '>= 1.4.35' | |||
| # spec.add_dependency 'train', '~> 1.4', '>= 1.4.35' | |||
There was a problem hiding this comment.
We should uncomment this 😄
There was a problem hiding this comment.
Yes once train is released we will update these 2
| out.exit_status.must_equal 0 | ||
| data = JSON.parse(out.stdout) | ||
| data.class.must_equal Array | ||
| data.size.must_be :>, 1 |
There was a problem hiding this comment.
Not sure how we officially feel about multiple arguments not being in ()...but I prefer it.
miah
approved these changes
Sep 13, 2018
Signed-off-by: Jared Quick <jquick@chef.io>
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jared Quick jquick@chef.io
Fixes #2488
This requires the downstream train PR to be merged first: inspec/train#347