Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Add support for 'bundles' migration #3384

Merged
merged 8 commits into from Sep 18, 2018
Merged

Plugins: Add support for 'bundles' migration #3384

merged 8 commits into from Sep 18, 2018

Conversation

clintoncwolfe
Copy link
Contributor

As part of the Plugins API v2 effort, we'll be gradually moving the 'bundles' into a 'plugins' area, along with their tests; and we'll be upgrading them to use the Plugin V2 API.

This PR does three things:

  • Configures the Loader to look in lib/plugins for v2 plugins
  • Adds some basic test helper code for use by 'core' plugins
  • Fixes a small handful of Loader issues discovered while developing the first plugin to use the plugins directory, the inspec-plugin-manager-cli.

@clintoncwolfe
Modify plugin loader to load core plugins from lib/inspec/plugins
d94562f 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe
Add test helper for core plugins
c3bc643 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe
Correct typo
5667ed4 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe
Correct activator name in search
5626fa2 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe clintoncwolfe added Type: Enhancement Improves an existing feature Component: Plugins Optional awesomeness labels Sep 12, 2018
@clintoncwolfe clintoncwolfe mentioned this pull request Sep 17, 2018
Closed
@chris-rock chris-rock mentioned this pull request Sep 17, 2018
Merged
jquick and others added 2 commits September 17, 2018 13:18
@jquick
Force aws require for the new order of tests.
30efe00 
Signed-off-by: Jared Quick <jquick@chef.io>
@chris-rock @jquick
load plugins if no argument is given (redirects to help) (#3402)
a93f0dc 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
jquick
jquick approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintoncwolfe ! Really nice foundation for our core plugins.

miah
miah approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintoncwolfe! Looks solid =)

@jquick
Fix linting.
5be39f2 
Signed-off-by: Jared Quick <jquick@chef.io>
@jquick
Fix test failure with new order.
3899d20 
Signed-off-by: Jared Quick <jquick@chef.io>
@clintoncwolfe clintoncwolfe merged commit 50ff9f6 into master Sep 18, 2018
@clintoncwolfe clintoncwolfe deleted the cw/plugins-core-support branch September 18, 2018 04:01
@clintoncwolfe clintoncwolfe restored the cw/plugins-core-support branch September 18, 2018 04:01
@jquick jquick deleted the cw/plugins-core-support branch September 18, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@jquick jquick jquick approved these changes

Assignees
No one assigned
Labels
Component: Plugins Optional awesomeness Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clintoncwolfe @miah @jquick @chris-rock