Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appveyor Config Changes #3983

Merged
merged 2 commits into from Apr 25, 2019
Merged

Appveyor Config Changes #3983

merged 2 commits into from Apr 25, 2019

Conversation

miah
Copy link
Contributor

@miah miah commented Apr 25, 2019

Enable 64bit Ruby for 24, 25, and 26.
Disable MSBuild mode entirely.

Signed-off-by: Miah Johnson miah@chia-pet.org

@miah
Enable 64bit Ruby for 24, 25, and 26.
b32c246 
Disable MSBuild mode entirely.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
clintoncwolfe
clintoncwolfe approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miah
-x64 should be included in the version.
4c3b883 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
zenspider
zenspider approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@zenspider zenspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would have preferred to change the PATH line, but this is totally fine. Gives us a bit more granularity.

@miah miah merged commit 7b004e9 into master Apr 25, 2019
@miah miah deleted the mj/appveyor branch April 25, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenspider zenspider zenspider approved these changes

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miah @zenspider @clintoncwolfe