Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump chefstyle and fix up flagged code. #4677

Merged
merged 2 commits into from Nov 9, 2019
Merged

Bump chefstyle and fix up flagged code. #4677

merged 2 commits into from Nov 9, 2019

Conversation

zenspider
Copy link
Contributor

Very minor.

I want to change a default config but I'll do that in a separate
commit since it is a bigger diff.

Signed-off-by: Ryan Davis zenspider@chef.io

@zenspider zenspider requested a review from a team as a code owner November 7, 2019 23:34
@ghost ghost requested review from clintoncwolfe and miah November 7, 2019 23:34
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Nov 7, 2019

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

clintoncwolfe
clintoncwolfe approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh...

@miah
Copy link
Contributor

miah commented Nov 8, 2019

Looks like one thing to fix

https://buildkite.com/chef-oss/inspec-inspec-master-verify/builds/1021#24fd3d11-69c4-41df-a5dd-d313f0b17d8e/726-733

@zenspider
Bump chefstyle and fix up flagged code.
8f1e607 
Very minor.

I want to change a default config but I'll do that in a separate
commit since it is a bigger diff.

Signed-off-by: Ryan Davis <zenspider@chef.io>
@zenspider
Switched chefstyle back to Layout/AlignArguments=with_first_argument.
bb49d58 
Fixed the flags mostly with `chefstyle -a` but also refactored/cleaned
some stuff by hand.

Signed-off-by: Ryan Davis <zenspider@chef.io>
@codeclimate
Copy link

codeclimate bot commented Nov 8, 2019

Code Climate has analyzed commit bb49d58 and detected 0 issues on this pull request.

View more on Code Climate.

@zenspider zenspider merged commit 244c7bb into master Nov 9, 2019
@chef-expeditor chef-expeditor bot deleted the zenspider/bump-chefstyle branch November 9, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

Assignees

@zenspider zenspider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zenspider @miah @clintoncwolfe