Change ffi pinning #5078
Merged
Change ffi pinning #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffi 1.13.1 reverts the breaking change in 1.13.0 We can now use any version other than specifically 1.13.0. Signed-off-by: James Stocks <jstocks@chef.io>
james-stocks
commented
Jun 10, 2020
| @@ -9,7 +9,7 @@ gem "inspec", path: "." | |||
| # in it in order to package the executable. Hence the odd backwards dependency. | |||
| gem "inspec-bin", path: "./inspec-bin" | |||
|
|
|||
| gem "ffi", [">= 1.9.14", "< 1.13"] # 1.13 does not work on Windows: https://github.com/ffi/ffi/issues/784 | |||
| gem "ffi", ">= 1.9.14", "!= 1.13.0" | |||
There was a problem hiding this comment.
The 1.9.14 seems to be there for historical reasons. If 1.13.1 is known to work then I think we should just change this to "ffi", ">= 1.13.1", "< 2.0"
Schwad
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi 1.13.1 reverts the breaking change in 1.13.0
We can now use any version other than specifically 1.13.0.
Signed-off-by: James Stocks jstocks@chef.io