Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rocky and almalinux to service resource #5604

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

sspans-sbp
Copy link
Contributor

Add support for rockylinux and almalinux to the service resource

Description

Currently the service resource doesn't support rockylinux and almalinux.

  Service chef-client
     ↺  The `service` resource is not supported on your OS yet.
  Service sshd
     ↺  The `service` resource is not supported on your OS yet.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • [ x] I have read the CONTRIBUTING document.

@sspans-sbp sspans-sbp requested a review from a team as a code owner July 22, 2021 11:41
@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for chef-inspec canceled.

🔨 Explore the source changes: b8677ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/614b02f9dd91600007884e54

@chef-expeditor
Copy link
Contributor

Hello sspans-sbp! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rjhornsby
Copy link

It looks like this is being held up because of a ruby version issue in the testing suite. Not sure how to fix that myself, but am hitting the resource not supported issue addressed by the PR. The change required to support Rocky and Almalinux is trivial.

Any chance we can get this looked at? Thanks!

@sspans-sbp
Copy link
Contributor Author

Not quite sure what the reason for the delay. This should be trivial to merge.

Signed-off-by: Sten Spans <sspans@schubergphilis.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@clintoncwolfe clintoncwolfe merged commit a0d03db into inspec:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants