Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inspec check docs for --format option #5617

Merged
merged 4 commits into from Sep 13, 2021

Conversation

Vasu1105
Copy link
Contributor

Signed-off-by: Vasu1105 vasundhara.jagdale@chef.io

Description

Updated docs for --format option to add a description and more details.

Related Issue

Fix #2971

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@Vasu1105 Vasu1105 requested review from a team as code owners August 16, 2021 08:19
@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ Deploy Preview for chef-inspec ready!

🔨 Explore the source changes: e02972a

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/61386090f4d16b0008a4f8dd

😎 Browse the preview: https://deploy-preview-5617--chef-inspec.netlify.app/inspec/cli

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
@Vasu1105 Vasu1105 force-pushed the vasundhara/inspec_check_docs_update branch from fc96c6a to 2f44f7b Compare August 19, 2021 08:42
@@ -64,7 +64,7 @@ inspec check PATH
This subcommand has additional options:

* ``--format=FORMAT``

The output format to use doc (default), json. If valid format is not provided then it will use the default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just checking that the inspec.yml is in a particular format? Wouldn't it just be yaml since it's a yaml file? Or is there JSON data embedded in the yaml file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspec check is a linting utility which checks several aspects of a profile, including the inspec.yml file. The --format flag controls the output format of inspec check. It provides a human-readable ("doc") format, and a machine-readable (json) format.

@clintoncwolfe clintoncwolfe added Aspect: Docs Write the Fine Manual Documentation ZH multi-repo label for the docs-team labels Aug 30, 2021
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@dkumaras
Copy link
Contributor

dkumaras commented Sep 7, 2021

Not sure the edits - esp the formats are fine - pls chk n let us know.

@@ -64,15 +63,15 @@ inspec check PATH
This subcommand has additional options:

* ``--format=FORMAT``

The output format to use doc (default), json. If valid format is not provided, then it will use the default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The output format to use doc (default), json. If valid format is not provided, then it will use the default.
The output format to use. Valid values: `json` and `doc`. Default value: `doc`.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@clintoncwolfe clintoncwolfe merged commit bb1763d into main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Docs Write the Fine Manual Documentation ZH multi-repo label for the docs-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: inspec check --format is undocumented
4 participants