Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option in postgres_session resource to establish socket connection #5664

Merged
merged 2 commits into from Sep 28, 2021

Conversation

Nik08
Copy link
Contributor

@Nik08 Nik08 commented Sep 16, 2021

Signed-off-by: Nikita Mathur nikita.mathur@chef.io

Add option in postgres_session resource to establish socket connection

Description

  • An optional parameter socket_path is added in postgres_session resource to establish socket based connection. Only works for unix based platforms.

Related Issue

Closes #5652

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

…gres

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 Nik08 self-assigned this Sep 16, 2021
@Nik08 Nik08 requested review from a team as code owners September 16, 2021 07:38
@netlify
Copy link

netlify bot commented Sep 16, 2021

✔️ Deploy Preview for chef-inspec ready!

🔨 Explore the source changes: a49181b

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/615191ac6fff620007edbfae

😎 Browse the preview: https://deploy-preview-5664--chef-inspec.netlify.app/inspec/resources/postgres_session

@github-actions github-actions bot added the Documentation ZH multi-repo label for the docs-team label Sep 16, 2021
where `its('output') { should eq '' }` compares the results of the query against the expected result in the test
where
- `its('output') { should eq '' }` compares the results of the query against the expected result in the test
- `socketpath` is an optional parameter. It can be used to establish socket connection with postgres by specifying one of the postgres unix domain sockets path. Only supported for unix based platforms.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `socketpath` is an optional parameter. It can be used to establish socket connection with postgres by specifying one of the postgres unix domain sockets path. Only supported for unix based platforms.
- `socketpath` is an optional parameter. Use `socketpath` to establish a socket connection with Postgres by specifying one of the Postgres Unix domain socket paths. Only supported on Unix-based platforms.

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation ZH multi-repo label for the docs-team Platform: Databases Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for unix sockets to postgres_session
4 participants