Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix google_container_node_pool.md #5696

Merged
merged 1 commit into from Oct 13, 2021
Merged

Fix google_container_node_pool.md #5696

merged 1 commit into from Oct 13, 2021

Conversation

pradeepbhadani
Copy link
Contributor

@pradeepbhadani pradeepbhadani commented Oct 12, 2021 •
edited

Signed-off-by: Pradeep Bhadani pradeep.bhadani@gmail.com

Description

Related Issue

#5695

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@pradeepbhadani pradeepbhadani requested review from a team as code owners October 12, 2021 21:53
@netlify
Copy link

netlify bot commented Oct 12, 2021 •
edited

✔️ Deploy Preview for chef-inspec ready!

🔨 Explore the source changes: ad3f128

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/616603eb5fa0ff00078bbe80

😎 Browse the preview: https://deploy-preview-5696--chef-inspec.netlify.app

@github-actions github-actions bot added the Documentation ZH multi-repo label for the docs-team label Oct 12, 2021
@chef-expeditor
Copy link
Contributor

Hello pradeepbhadani! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@clintoncwolfe clintoncwolfe merged commit d868356 into inspec:main Oct 13, 2021
@pradeepbhadani pradeepbhadani deleted the issue_5695 branch October 13, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@alexpop alexpop Awaiting requested review from alexpop alexpop is a code owner automatically assigned from inspec/inspec-core-team

@Nik08 Nik08 Awaiting requested review from Nik08 Nik08 is a code owner automatically assigned from inspec/inspec-core-team

Assignees
No one assigned
Labels
Documentation ZH multi-repo label for the docs-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined method `node_config' for google_container_node_pool
2 participants
@pradeepbhadani @clintoncwolfe