Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds user_permissions property and be_inherited matcher to the file resource for Windows. #5775

Merged
merged 6 commits into from
Jan 20, 2022

Conversation

Vasu1105
Copy link
Contributor

@Vasu1105 Vasu1105 commented Dec 22, 2021

Signed-off-by: Vasu1105 vasundhara.jagdale@chef.io

Description

  • Adds user_permissions property for the file resource to get all the user and group permissions.
  • Adds be_inherited matcher to check whether the file has enabled inheritance on Windows.
  • Updated docs.

Related Issue

Fixes #5768

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@Vasu1105 Vasu1105 requested a review from a team as a code owner December 22, 2021 13:11
@netlify
Copy link

netlify bot commented Dec 22, 2021

✔️ Deploy Preview for chef-inspec ready!

🔨 Explore the source changes: c1537f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/61dea5e90355670007d82057

😎 Browse the preview: https://deploy-preview-5775--chef-inspec.netlify.app

@Vasu1105 Vasu1105 changed the title Adds property file_permissions and be_inherit matcher to the file resource for Windows. [W.I.P]Adds property file_permissions and be_inherit matcher to the file resource for Windows. Dec 22, 2021
@Vasu1105 Vasu1105 changed the title [W.I.P]Adds property file_permissions and be_inherit matcher to the file resource for Windows. [W.I.P]Adds property users_permissions and be_inherit matcher to the file resource for Windows. Dec 22, 2021
@Vasu1105 Vasu1105 requested a review from a team as a code owner December 22, 2021 14:23
@github-actions github-actions bot added the Documentation ZH multi-repo label for the docs-team label Dec 22, 2021
@Vasu1105 Vasu1105 changed the title [W.I.P]Adds property users_permissions and be_inherit matcher to the file resource for Windows. [W.I.P]Adds property user_permissions and be_inherit matcher to the file resource for Windows. Dec 22, 2021
@Vasu1105 Vasu1105 changed the title [W.I.P]Adds property user_permissions and be_inherit matcher to the file resource for Windows. Adds property user_permissions and be_inherit matcher to the file resource for Windows. Dec 22, 2021
@Vasu1105 Vasu1105 force-pushed the vasundhara/add_new_property_file_resource branch 6 times, most recently from 3929447 to c117aa8 Compare December 27, 2021 12:59
@Vasu1105 Vasu1105 changed the title Adds property user_permissions and be_inherit matcher to the file resource for Windows. Adds user_permissions property and be_inherit matcher to the file resource for Windows. Dec 27, 2021
@Vasu1105 Vasu1105 force-pushed the vasundhara/add_new_property_file_resource branch from c117aa8 to c1fb9f8 Compare December 27, 2021 14:03
@@ -587,3 +596,11 @@ return `true` if your file has a mode with greater permissions than specified.
it { should_not be_more_permissive_than('0644') }
it { should be_more_permissive_than('0000') }
end

### `be_inherit`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this to "be_inherited".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @clintoncwolfe. Did the required changes.

@Vasu1105 Vasu1105 changed the title Adds user_permissions property and be_inherit matcher to the file resource for Windows. Adds user_permissions property and be_inherited matcher to the file resource for Windows. Jan 10, 2022
@Vasu1105 Vasu1105 force-pushed the vasundhara/add_new_property_file_resource branch from e7e0fe5 to a344cc8 Compare January 12, 2022 05:53
…ource for Windows.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Vasu1105 and others added 2 commits January 12, 2022 15:26
Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>
Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
@Vasu1105 Vasu1105 force-pushed the vasundhara/add_new_property_file_resource branch from a344cc8 to c1537f9 Compare January 12, 2022 09:56
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Vasu1105
Copy link
Contributor Author

@IanMadd if everything looks good could you please approve this PR?

@clintoncwolfe clintoncwolfe merged commit 19fb98f into main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation ZH multi-repo label for the docs-team Expeditor: Bump Minor Version Type: New Feature Adds new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIKE]- Enhancements for windows file resource - explicit windows_rights
3 participants