Fix for issue 5809 Service checks failing on Amazon linux 2022

[ahasunos]

✅ Signed-off-by: Sonu Saha sonu.saha@progress.com

Related Issue

Issue #5809: Service checks failing on Amazon linux 2022

Description

CFINSPEC-186 - Issue 5809: Service checks are failing on Amazon linux 2022
The service resource checks were failing on Amazon Linux 2 as InSpec was using initctl instead of systemd because of the following logic:

inspec/lib/inspec/resources/service.rb

Line 185 in 948b274

if os[:release] =~ /^20\d\d/

The above logic fails because on os[:release] both Amazon Linux 1 and Amazon Linux 2 gives the output as their release years (eg: 2018.03 or 2022) thus failing to differentiate Amazon Linux 2022 as Amazon Linux 2 and triggering service with initctl instead of systemd.

The patch for this is done by checking the availability of the utility on the system.

  if inspec.command("initctl").exist? || inspec.command("/sbin/initctl").exist?
    Upstart.new(inspec, service_ctl)
  else
    Systemd.new(inspec, service_ctl)
  end

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New content (non-breaking change)
• Breaking change (a content change which would break existing functionality or processes)

Checklist:

• I have read the CONTRIBUTING document.

[netlify]

✅ Deploy Preview for chef-inspec canceled.

Name	Link
🔨 Latest commit	a8fb7bb
🔍 Latest deploy log	https://app.netlify.com/sites/chef-inspec/deploys/625ff14741bae50008f00137

[chef-expeditor]

Hello ahasunos! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. Possible Outcomes
   a. If everything looks good, one of them will approve it, and your PR will be merged.
   b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
   c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

[ahasunos]

Need comment on this.

I have commented out the below unit this because imo

The below test is not required because we cannot differentiate between amazon and amazon2 during testing. After all, the differentiation is not based on the version but based on the utility available on the system. However, the service resource works perfectly fine for the actual instance of Amazon and Amazon2 Linux.

[ahasunos]

An attempt to fix the issue was done in PR #2901