CFINSPEC-246/CFINSPEC-247 Attestation changes for N/R outcomes #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
… the control - fix in streaming reporter Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
…iles Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
…tions file Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
…aming reporter Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
✅ Deploy Preview for chef-inspec canceled.
|
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
…station file Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Vasu1105
reviewed
Aug 2, 2022
lib/inspec/attestations.rb
Outdated
| # logic to find expiration date using frequency and updated date. | ||
| updated_last = attestation_data["updated"] | ||
| begin | ||
| if updated_last.is_a?(Date) || (updated_last.is_a?(String) && Date.parse(updated_last).year != 0) |
There was a problem hiding this comment.
Maybe you can write this whole bunch of if and else in another method to make it cleaner.
There was a problem hiding this comment.
Sure, let me think about how I can logically separate those lines since I think they are part of the logic used for fetching the expiration date.
dkumaras
approved these changes
Aug 2, 2022
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Vasu1105
reviewed
Aug 3, 2022
lib/inspec/attestations.rb
Outdated
| ui.exit(:usage_error) | ||
| end | ||
| end | ||
| end | ||
|
|
||
| def self.fetch_expiry_using_frequency_and_updated_date(updated_date, frequency, control_id) |
There was a problem hiding this comment.
Maybe this method name can be reduced to fetch_expiry_date as its arguments are self-explanatory in that they need, updated_date and frequency. You can add code comments.
There was a problem hiding this comment.
I think the method name should also explain its usage. So it seems fine to me.
There was a problem hiding this comment.
No problem I felt it's too long :)
clintoncwolfe
approved these changes
Aug 4, 2022
Vasu1105
approved these changes
Aug 5, 2022
Nik08
force-pushed
the
nm/attestations-feature
branch
from
963e0e9
to
c5c49fb
Compare
…ation using frequency and updated date Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Nik08
force-pushed
the
nm/attestations-feature
branch
from
c5c49fb
to
9c04848
Compare
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attestation feature which enables attesting N/R controls and marking them
passorfailmanually using a file option--attestation-fileRelated Issue
Types of changes
Checklist: